Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-inputs): use correct variables delimiters for default variables [TCTC-8076] #2037

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

alice-sevin
Copy link
Contributor

@alice-sevin alice-sevin commented Mar 11, 2024

In a previous PR: #1988, we updated the delimiters for relative variables but we forgot to do it for default variables (TODAY, YESTERDAY), picked in variables list not in relative date form.
We add logic to retrieve correct delimiters depending on if the variable is trusted or not.

@alice-sevin alice-sevin added bug Something isn't working need review labels Mar 11, 2024
@alice-sevin alice-sevin self-assigned this Mar 11, 2024
Copy link
Member

@davinov davinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thx!

@alice-sevin alice-sevin merged commit 61e1a97 into master Mar 11, 2024
2 checks passed
@alice-sevin alice-sevin deleted the fix/date-input-variable-delimiters branch March 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants