chore: code review feedback

ToucanToco · Jan 17, 2024 · 3696cda · 3696cda
1 parent ed48ea2
commit 3696cda
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/server/src/weaverbird/pipeline/steps/utils/combination.py b/server/src/weaverbird/pipeline/steps/utils/combination.py
@@ -115,15 +115,14 @@ async def resolve_if_reference(
 
 async def _resolve_references_in_pipeline(
     reference_resolver: ReferenceResolver,
-    pipeline: list,
-):
+    pipeline: list[PipelineStepWithRefs | PipelineStep],
+) -> PipelineOrDomainName | None:
     from weaverbird.pipeline.pipeline import PipelineWithRefs, ReferenceUnresolved
 
-    if isinstance(pipeline, list):
-        # Recursively resolve any reference in sub-pipelines
-        pipeline_with_refs = PipelineWithRefs(steps=pipeline)
-        try:
-            pipeline_without_refs = await pipeline_with_refs.resolve_references(reference_resolver)
-            return pipeline_without_refs.model_dump()["steps"]
-        except ReferenceUnresolved:
-            return None  # skip
+    # Recursively resolve any reference in sub-pipelines
+    pipeline_with_refs = PipelineWithRefs(steps=pipeline)
+    try:
+        pipeline_without_refs = await pipeline_with_refs.resolve_references(reference_resolver)
+        return pipeline_without_refs.model_dump()["steps"]
+    except ReferenceUnresolved:
+        return None  # skip