feat: add authentication configs (TCTC-9914) #1842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-pinchelimouroux
added
enhancement
julien-pinchelimouroux
changed the title
|
|
||
| Call refresh token route if the access token has expired. | ||
| """ | ||
| oauth_token_info = self._secrets_keeper.load(self.auth_flow_id) |
There was a problem hiding this comment.
model pydantic
Fanaen
approved these changes
Jan 17, 2025
lukapeschke
reviewed
Jan 17, 2025
Comment on lines
+46
to
+57
| if isinstance(token_response["expires_at"], str): | ||
| expires_at = None | ||
| for date_format in _SUPPORTED_EXPIRATION_FORMATS: | ||
| try: | ||
| expires_at = datetime.strptime(token_response["expires_at"], date_format) | ||
| break | ||
| except ValueError: | ||
| continue | ||
| if expires_at is not None: | ||
| return expires_at | ||
| raise ValueError(f"Can't parse the oauth2 token expiration: {token_response['expires_at']}") | ||
| return datetime.fromtimestamp(int(token_response["expires_at"])) |
There was a problem hiding this comment.
could we maybe use a pydanti validator for that ? It would handle key errors, type errors etc
| raise ValueError(f"Can't parse the oauth2 token expiration: {token_response['expires_at']}") | ||
| return datetime.fromtimestamp(int(token_response["expires_at"])) | ||
| else: | ||
| return datetime.now() + timedelta(0, int(token_response.get("expires_in", default_lifetime))) |
There was a problem hiding this comment.
note: dateutil's timedelta is smarter. Also, you you please use kwargs for the timedelta ?
|
|
||
| :param workflow_callback_context: the context which will be passed to the workflow token saver callback | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Suggested change
| pass |
can be omitted when there's a docstring
| authorization_response: str, | ||
| ): | ||
| """Retrieve authorization token from oauth2 backend""" | ||
| pass |
| raise MissingOauthWorkflowError() | ||
|
|
||
| # Verify the oauth2 workflow token | ||
| assert workflow_token == JsonWrapper.loads(url_params["state"][0])["workflow_token"] |
There was a problem hiding this comment.
same here, could we use pydantic to load the params ? They're user-provided input so it could be anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new
authenticationconfiguration onHTTP APIconnectorsEverything is described in the PAT : https://toucantoco.atlassian.net/wiki/spaces/TTA/pages/4645355521/PAT+278+--+HTTP+connector+oAuth2+management