feat: extend fastexcel support to python >= 3.8 (#152)

* feat: extend support to python 3.8+

* update release workflow

* don't forget 3.8 for macos

* Update .github/workflows/release.yml

---------

Co-authored-by: Luka Peschke <[email protected]>
Co-authored-by: Luka Peschke <[email protected]>

.github/workflows/CI.yml

@@ -12,10 +12,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Python python3.10
+    - name: Set up Python
       uses: actions/setup-python@v5
       with:
         python-version: "${{ matrix.python-version }}"
@@ -49,7 +49,7 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        python-version: ["3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v4
     - name: build (fast)

.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v4
     - name: build (release)
@@ -30,7 +30,7 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        python-version: ["3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v4
     - name: build (release)
@@ -51,6 +51,16 @@ jobs:
     runs-on: ubuntu-latest
     needs: [linux, macos]
     steps:
+    - name: Download Linux 3.8 wheels
+      uses: actions/download-artifact@v4
+      with:
+        name: "wheels-linux-python-3.8"
+        path: wheels-linux
+    - name: Download Linux 3.9 wheels
+      uses: actions/download-artifact@v4
+      with:
+        name: "wheels-linux-python-3.9"
+        path: wheels-linux
     - name: Download Linux 3.10 wheels
       uses: actions/download-artifact@v4
       with:
@@ -67,6 +77,16 @@ jobs:
         name: "wheels-linux-python-3.12"
         path: wheels-linux
 
+    - name: Download MacOS 3.8 wheels
+      uses: actions/download-artifact@v4
+      with:
+        name: "wheels-macos-python-3.8"
+        path: wheels-macos
+    - name: Download MacOS 3.9 wheels
+      uses: actions/download-artifact@v4
+      with:
+        name: "wheels-macos-python-3.9"
+        path: wheels-macos
     - name: Download MacOS 3.10 wheels
       uses: actions/download-artifact@v4
       with:

.gitignore

@@ -5,7 +5,9 @@ __pycache__
 *.pyc
 *.so
 *.dat
+
 .python-version
 .venv
 docs
+.idea
 .benchmarks

README.md

@@ -10,7 +10,7 @@ Docs available [here](https://fastexcel.toucantoco.dev/).
 
 ### Prerequisites
 
-Python>=3.10 and a recent Rust toolchain must be installed on your machine. `cargo` must be available in your `PATH`.
+Python>=3.8 and a recent Rust toolchain must be installed on your machine. `cargo` must be available in your `PATH`.
 
 ### First setup
 
@@ -31,7 +31,7 @@ This will compile the wheel (in debug mode) and install it. It will then be avai
 
 ### Installing the project in prod mode
 
-This is required for profiling, as dev mdoe wheels are much slower. `make prod-install` will compile the project
+This is required for profiling, as dev mode wheels are much slower. `make prod-install` will compile the project
 in release mode and install it in your local venv, overriding previous dev installs.
 
 ### Linting and formatting

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "maturin"
 
 [project]
 name = "fastexcel"
-requires-python = ">=3.10"
+requires-python = ">=3.8"
 classifiers = [
     "Programming Language :: Rust",
     "Programming Language :: Python :: Implementation :: CPython",
@@ -27,7 +27,7 @@ python-source = "python"
 module-name = "fastexcel._fastexcel"
 
 [tool.mypy]
-python_version = "3.10"
+python_version = "3.8"
 follow_imports = "silent"
 ignore_missing_imports = true
 # A few custom options
@@ -45,4 +45,4 @@ testpaths = [
 line-length = 100
 
 # Enable Pyflakes `E` and `F` codes by default.
-select = ["E", "F", "Q"]
+select = ["E", "F", "I", "Q", "FA102"]

python/fastexcel/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:

python/fastexcel/_fastexcel.pyi

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import pyarrow as pa
 
 class _ExcelSheet:

python/tests/benchmarks/memory.py

@@ -1,5 +1,6 @@
-from enum import Enum
 import argparse
+from enum import Enum
+
 from readers import fastexcel_read, pyxl_read, xlrd_read
 
 
@@ -18,13 +19,14 @@ def get_args() -> argparse.Namespace:
 
 def main():
     args = get_args()
-    match args.engine:
-        case Engine.FASTEXCEL:
-            fastexcel_read(args.file)
-        case Engine.XLRD:
-            xlrd_read(args.file)
-        case Engine.OPENPYXL:
-            pyxl_read(args.file)
+    engine = args.engine
+
+    if engine == Engine.FASTEXCEL:
+        fastexcel_read(args.file)
+    elif engine == Engine.XLRD:
+        xlrd_read(args.file)
+    elif engine == Engine.OPENPYXL:
+        pyxl_read(args.file)
 
 
 if __name__ == "__main__":

python/tests/test_durations.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from datetime import date, datetime, timedelta
 
 import fastexcel
@@ -11,7 +13,6 @@
 from polars.datatypes import PolarsDataType
 from polars.datatypes import Utf8 as PlUtf8
 from polars.testing import assert_frame_equal as pl_assert_frame_equal
-
 from utils import path_for_fixture
 
 

python/tests/test_empty.py

@@ -1,6 +1,5 @@
 import fastexcel
 import pytest
-
 from utils import path_for_fixture
 
 

python/tests/test_fastexcel.py

@@ -4,7 +4,6 @@
 import pytest
 from pandas.testing import assert_frame_equal as pd_assert_frame_equal
 from polars.testing import assert_frame_equal as pl_assert_frame_equal
-
 from utils import path_for_fixture