Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: task is constantly retrying #43

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix: task is constantly retrying #43

merged 2 commits into from
Jul 1, 2024

Conversation

PabloReszczynski
Copy link
Collaborator

The Task constructor uses regular comparison in the args function to know if the task should be re-fired. Because we were constructing an object in each call, even if it contained the same data, its hash meant the objects were different.

@PabloReszczynski PabloReszczynski self-assigned this Jun 28, 2024
@anonvt
Copy link
Contributor

anonvt commented Jun 28, 2024

I'm trying to test locally but I'm getting
Couldn't load Banner. Check console for more details.
token and slot are set properly, not sure what's up since there's no errors in the console.

@PabloReszczynski
Copy link
Collaborator Author

PabloReszczynski commented Jul 1, 2024 •
edited
Loading

@anonvt I think I fixed the issue, but I can't test it. Damn cors problems. @jbergstroem do you remember how to fix those? I can't call the auctions api from localhost:5173 because it throws a cors error. (nvm I got it working)

anonvt
anonvt approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@anonvt anonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced locally and it worked.
LGTM!

@PabloReszczynski PabloReszczynski merged commit 055ff63 into main Jul 1, 2024
4 checks passed
@PabloReszczynski PabloReszczynski deleted the fix/p/set-correct-params-in-task branch July 1, 2024 13:36
anonvt pushed a commit that referenced this pull request Jul 1, 2024
@PabloReszczynski @anonvt
fix: task is constantly retrying (#43)
c0eb421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonvt anonvt anonvt approved these changes

@jbergstroem jbergstroem Awaiting requested review from jbergstroem

Assignees

@PabloReszczynski PabloReszczynski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloReszczynski @anonvt