Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to open target in a new tab #40

Merged
merged 5 commits into from
Jul 1, 2024
Merged

feat: add option to open target in a new tab #40

merged 5 commits into from
Jul 1, 2024

Conversation

anonvt
Copy link
Contributor

@anonvt anonvt commented Jun 27, 2024

@anonvt anonvt marked this pull request as ready for review June 28, 2024 01:09
@anonvt anonvt mentioned this pull request Jun 28, 2024
Merged
PabloReszczynski
PabloReszczynski requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@PabloReszczynski PabloReszczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

banner tags are not anchor tags, with this I mean that we shouldn't leak implementation details of the inner anchor of the banner.

README.md Outdated Show resolved Hide resolved
@anonvt anonvt force-pushed the gui/feat/click-to-newtab branch from 3739fac to 7d778ed Compare June 28, 2024 17:01
@anonvt anonvt requested a review from PabloReszczynski June 28, 2024 17:21
@anonvt anonvt force-pushed the gui/feat/click-to-newtab branch from ef22916 to d2213fd Compare July 1, 2024 13:52
PabloReszczynski
PabloReszczynski approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@PabloReszczynski PabloReszczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm. I still think the API could be improved related to custom elements by the user, but we can think on that later in the future.

README.md Outdated Show resolved Hide resolved
@anonvt @PabloReszczynski
Update README.md
f972c2e 
Co-authored-by: Pablo Reszczynski <[email protected]>
@anonvt anonvt merged commit c00ef80 into main Jul 1, 2024
4 checks passed
@anonvt anonvt deleted the gui/feat/click-to-newtab branch July 1, 2024 17:45
anonvt added a commit that referenced this pull request Jul 1, 2024
@anonvt
feat: add option to open target in a new tab (#40)
9e5ea3d 
feat: add option to open target in a new tab 

PR: #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloReszczynski PabloReszczynski PabloReszczynski approved these changes

@jasanchez1 jasanchez1 Awaiting requested review from jasanchez1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonvt @PabloReszczynski