Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump vitest and @vitest/coverage-v8 #225

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2024

Bumps vitest and @vitest/coverage-v8. These dependencies needed to be updated together.
Updates vitest from 0.33.0 to 1.2.2

Release notes

Sourced from vitest's releases.

v1.2.2

   🐞 Bug Fixes

    View changes on GitHub

v1.2.1

   🐞 Bug Fixes

    View changes on GitHub

v1.2.0

... (truncated)

Commits
  • b1462a4 chore: release v1.2.2
  • 6689856 fix(coverage): don't crash when re-run removes earlier run's reports (#5022)
  • fff1a27 fix(vitest): don't throw an error if mocked file was already imported (#5050)
  • 6dae3fe fix(typecheck): fix ignoreSourceErrors in run mode (#5044)
  • cf5641a fix(vitest): support older NodeJS with async import.meta.resolve (#5045)
  • 915d6c4 fix(threads): mention common work-around for the logged error (#5024)
  • a9a486f fix(vitest): allow useFakeTimers to fake requestIdleCallback on non brows...
  • 253df1c fix(vitest): throw an error if vi.mock is exported (#5034)
  • 7344870 feat(vitest): expose getHooks & setHooks (#5032)
  • 9c7c0fc fix(vitest): test deep dependencies change detection (#4934)
  • Additional commits viewable in compare view

Updates @vitest/coverage-v8 from 0.34.6 to 1.2.2

Release notes

Sourced from @​vitest/coverage-v8's releases.

v1.2.2

   🐞 Bug Fixes

    View changes on GitHub

v1.2.1

   🐞 Bug Fixes

    View changes on GitHub

v1.2.0

... (truncated)

Commits
  • b1462a4 chore: release v1.2.2
  • d53b858 fix(coverage): remove coverage/.tmp files after run (#5008)
  • 6421c27 chore: release v1.2.1
  • 4b41131 fix(coverage): thresholds.autoUpdate to work with arrow function configurat...
  • b561c32 chore: release v1.2.0
  • 96dc6e9 feat(coverage): custom reporter support (#4828)
  • a73c1c2 chore: release v1.1.3
  • be5a259 chore: release v1.1.2
  • c8abbc1 chore: release v1.1.1
  • 9497f48 chore: release v1.1.0
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 1, 2024
@dependabot dependabot bot requested a review from sk- February 1, 2024 00:15
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/vitest-and-vitest/coverage-v8-1.2.2 branch 2 times, most recently from c529805 to b310285 Compare February 7, 2024 11:37
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) and [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8). These dependencies needed to be updated together.

Updates `vitest` from 0.33.0 to 1.2.2
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v1.2.2/packages/vitest)

Updates `@vitest/coverage-v8` from 0.34.6 to 1.2.2
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v1.2.2/packages/coverage-v8)

---
updated-dependencies:
- dependency-name: vitest
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: "@vitest/coverage-v8"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/vitest-and-vitest/coverage-v8-1.2.2 branch from b310285 to 1caa450 Compare February 7, 2024 11:40
@sk-
Copy link
Contributor

sk- commented Feb 7, 2024

@jbergstroem any idea how to fix the typing issue? Seem to be related to how packages are released now.

Also the coverage dropped a lot.

@jbergstroem
Copy link
Member

I will take a look when I have a moment

@jbergstroem
Copy link
Member

jbergstroem commented Feb 12, 2024

@jbergstroem any idea how to fix the typing issue? Seem to be related to how packages are released now.

Also the coverage dropped a lot.

Looked into this - we're falling behind a bit on a lot of deps (which has major / breaking updates). I think the best way forward is probably refactoring things a bit for the test harness (I recall talking about this a while ago) - use the vite builtin server instead of express and update the mocks in msw (rest is no more; we need to use http. and HttpResponse).

The coverage drop is due to having no coverage for mocks/api-server.ts nor src/events.ts.

@sk-
Copy link
Contributor

sk- commented Feb 15, 2024

@jbergstroem Thanks for the investigation. That would be a major refactor as currently those e2e tests are run manually.

We would need to change the tests to be run automatically (ideally in browser mode) and then we would be able to use mws.

What I don't get is that compiling an express app should still work.

@jbergstroem
Copy link
Member

@jbergstroem Thanks for the investigation. That would be a major refactor as currently those e2e tests are run manually.

I already started locally; low prio but I think having playwright running the tests is the way to go. That way, we can also cover multipe browsers, phones, etc.

We would need to change the tests to be run automatically (ideally in browser mode) and then we would be able to use mws.

What I don't get is that compiling an express app should still work.

Yeah; I can look at that specifically today.

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 1, 2024

Superseded by #233.

@dependabot dependabot bot closed this Mar 1, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/vitest-and-vitest/coverage-v8-1.2.2 branch March 1, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants