Remove kleur #176
Open
Remove kleur #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreDemailly
requested changes
Jan 2, 2025
fabnguess
force-pushed
the
remove_kleur
branch
from
46e18fd to
af56edb
Compare
fabnguess
force-pushed
the
remove_kleur
branch
from
af56edb to
e416b73
Compare
fabnguess
force-pushed
the
remove_kleur
branch
2 times, most recently
from
04220e7 to
479978a
Compare
PierreDemailly
requested changes
Jan 2, 2025
fabnguess
force-pushed
the
remove_kleur
branch
from
479978a to
a31ed56
Compare
|
We need to add |
fabnguess
force-pushed
the
remove_kleur
branch
from
a31ed56 to
5fd2109
Compare
PierreDemailly
approved these changes
Jan 3, 2025
fraxken
reviewed
Jan 3, 2025
Comment on lines
-77
to
86
| if (color === null) { | ||
| this.#color = (str: string) => str; | ||
| } | ||
| else { | ||
| this.#color = color in kleur ? kleur[color] : kleur.white; | ||
|
|
||
| const colors = Array.isArray(color) ? color : [color]; | ||
|
|
||
| if (colors.every((color) => kAvailableColors.has(color)) === false) { | ||
| throw new Error("Invalid color given"); | ||
| } |
There was a problem hiding this comment.
We removed the assignment to colors property so nothing work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.