Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voc2coco.py #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −18
Open

Update voc2coco.py #11

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fcfe0c
Update voc2coco.py
May 26, 2021
48ca615
Update voc2coco.py
Jun 9, 2021
3d3d555
Update voc2coco.py
Jun 16, 2021
c45e44f
Update voc2coco.py
Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions voc2coco.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,6 @@ def get_and_check(root, name, length):
return vars


def get_filename_as_int(filename):
try:
filename = filename.replace("\\", "/")
filename = os.path.splitext(os.path.basename(filename))[0]
return int(filename)
except:
raise ValueError("Filename %s is supposed to be an integer." % (filename))


def get_categories(xml_files):
"""Generate category name to id mapping from a list of xml files.

Expand Down Expand Up @@ -73,7 +64,7 @@ def convert(xml_files, json_file):
else:
categories = get_categories(xml_files)
bnd_id = START_BOUNDING_BOX_ID
for xml_file in xml_files:
for idx, xml_file in enumerate(xml_files):
tree = ET.parse(xml_file)
root = tree.getroot()
path = get(root, "path")
Expand All @@ -83,8 +74,8 @@ def convert(xml_files, json_file):
filename = get_and_check(root, "filename", 1).text
else:
raise ValueError("%d paths found in %s" % (len(path), xml_file))
## The filename must be a number
image_id = get_filename_as_int(filename)
# The 'index' is given as img_id
image_id = idx
size = get_and_check(root, "size", 1)
width = int(get_and_check(size, "width", 1).text)
height = int(get_and_check(size, "height", 1).text)
Expand All @@ -105,10 +96,10 @@ def convert(xml_files, json_file):
categories[category] = new_id
category_id = categories[category]
bndbox = get_and_check(obj, "bndbox", 1)
xmin = int(get_and_check(bndbox, "xmin", 1).text) - 1
ymin = int(get_and_check(bndbox, "ymin", 1).text) - 1
xmax = int(get_and_check(bndbox, "xmax", 1).text)
ymax = int(get_and_check(bndbox, "ymax", 1).text)
xmin = int(float(get_and_check(bndbox, "xmin", 1).text)) - 1
ymin = int(float(get_and_check(bndbox, "ymin", 1).text)) - 1
xmax = int(float(get_and_check(bndbox, "xmax", 1).text))
ymax = int(float(get_and_check(bndbox, "ymax", 1).text))
assert xmax > xmin
assert ymax > ymin
o_width = abs(xmax - xmin)
Expand Down Expand Up @@ -143,8 +134,8 @@ def convert(xml_files, json_file):
parser = argparse.ArgumentParser(
description="Convert Pascal VOC annotation to COCO format."
)
parser.add_argument("xml_dir", help="Directory path to xml files.", type=str)
parser.add_argument("json_file", help="Output COCO format json file.", type=str)
parser.add_argument("--xml_dir", help="Directory path to xml files.", type=str)
parser.add_argument("--json_file", help="Output COCO format json file.", type=str)
args = parser.parse_args()
xml_files = glob.glob(os.path.join(args.xml_dir, "*.xml"))

Expand Down