Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for controller continuing to vibrate with "Make Controller Invisible On Interaction" #132

Closed
wants to merge 1 commit into from

Conversation

massycat
Copy link

When "Make Controller Invisible On Interaction" is selected and you interact with a NVRInteractableRotator or similar the controller can continue to vibrate after you have stopped the interaction.
When NVRHand sets the controller to Invisible it disables all the hand colliders on the model. Therefore the OnTriggerExit method in NVRHand will not be called when the hand colliders leave the Interactable collider. This means that CurrentlyHoveringOver will not be updated.
Therefore, to fix, CurrentlyHoveringOver is cleared in the SetVisibility method.

@zite
Copy link
Member

zite commented Apr 8, 2017

Thanks for this fix @massycat. I'm not taking it because the colliders aren't actually supposed to be disabled in this scenario, just the renderers. So I've gone ahead and just taken out that code and it seems to work. Let me know if you are still running into the issue.

@zite zite closed this Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants