Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LDAP-45] Search strategy internal search fixes #31

Merged
merged 12 commits into from
Feb 29, 2024
Merged

[LDAP-45] Search strategy internal search fixes #31

merged 12 commits into from
Feb 29, 2024

Conversation

Sylinsic
Copy link
Contributor

Convert to LdapSearch instead of LdapInternalSearch in sync strategies
Configure paging for latest sync token in Generic sync strategy (with configuration option)
Remove targetEntryUUID from generic sync strategy
Provide option to override built in search filters
Enable changelog on OpenDJ instance

Sylinsic and others added 10 commits February 19, 2024 19:30
targetEntryUUID isn't part of the standard so directories such as isode m-vault don't use this field. This prevents delete functionality when using entryUUID as a uid attribute (which does exist on isode m-vault).

This change allows using targetDN as the uid to compare against: implementing a new PullCorrelationRule, the __UID__ can be used to compare agains the object DN, enabling the deletion functionality
Copy link
Member

@ilgrosso ilgrosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have streamlined a few things with my commit (including removal of the introduced LdapUtil#getStringAttrValue).

The two changelog sync startegy classes contain a considerable amount of duplicated code: a common super class must be introduced.

@Sylinsic Sylinsic requested a review from ilgrosso February 28, 2024 09:13
Copy link
Contributor Author

@Sylinsic Sylinsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes make sense to me!

@ilgrosso ilgrosso merged commit 903cdf4 into Tirasa:master Feb 29, 2024
3 checks passed
@Sylinsic
Copy link
Contributor Author

Hey @ilgrosso, I was wondering if there was any indication as to when 1.3.9 (including this update) would be released as a full version please? Also, 1.3.10 of AD as it's in a similar situation of having functionality added but not a full release. Cheers, sylinsic

@ilgrosso
Copy link
Member

@Sylinsic please subscribe to the connid-dev@ group and let's discuss there of such non-technical items. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants