[LDAP-41] Provide capability for different sync strategies #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apSyncStrategy Update LdapConnector to get LdapSyncStrategy from config value
ilgrosso
requested changes
Jan 19, 2024
src/main/java/net/tirasa/connid/bundles/ldap/LdapConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tirasa/connid/bundles/ldap/LdapConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tirasa/connid/bundles/ldap/LdapConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tirasa/connid/bundles/ldap/LdapConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tirasa/connid/bundles/ldap/LdapConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/net/tirasa/connid/bundles/ldap/sync/sunds/SunDSChangeLogSyncStrategy.java
Outdated
Show resolved
Hide resolved
ilgrosso
previously approved these changes
Jan 19, 2024
|
@Sylinsic I've made a few more adjustments. |
ilgrosso
previously approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is only possible to utilise the SunDSChangeLogSyncStrategy method. This is not ideal as not all companies implement changelogs in the same fashion. There should be a method to select a SyncStrategy, as is the case with the ADBundle, which is suitable for the software being connected to.