Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify workflow. #300

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Simplify workflow. #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e38149
Simplify workflow.
NullHypothesis Mar 15, 2024
3bdbd24
Remove sourcing of deleted file.
NullHypothesis Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/scripts/install_tiledb_linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
set -e -x
source "$(dirname $0)/tiledb-version.sh"
curl --location -o tiledb.tar.gz https://github.com/TileDB-Inc/TileDB/releases/download/${TILEDB_VERSION}/tiledb-linux-x86_64-${TILEDB_VERSION}-${COMMIT_ID}.tar.gz \
curl --location -o tiledb.tar.gz https://github.com/TileDB-Inc/TileDB/releases/download/${CORE_VERSION}/tiledb-linux-x86_64-${CORE_VERSION}-${CORE_HASH}.tar.gz \
&& sudo tar -C /usr/local -xf tiledb.tar.gz
sudo ldconfig /usr/local/lib
3 changes: 1 addition & 2 deletions .github/scripts/install_tiledb_linux_debug.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
set -e -x
source "$(dirname $0)/tiledb-version.sh"
git clone https://github.com/TileDB-Inc/TileDB.git -b ${TILEDB_VERSION}
git clone https://github.com/TileDB-Inc/TileDB.git -b ${CORE_VERSION}
cd TileDB
mkdir build && cd build
cmake -DTILEDB_WERROR=OFF -DTILEDB_VCPKG=ON -DSANITIZER=leak -DTILEDB_VERBOSE=OFF -DTILEDB_S3=ON -DTILEDB_SERIALIZATION=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/usr/local ..
Expand Down
3 changes: 1 addition & 2 deletions .github/scripts/install_tiledb_macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
set -e -x
source "$(dirname $0)/tiledb-version.sh"
curl --location -o tiledb.tar.gz https://github.com/TileDB-Inc/TileDB/releases/download/${TILEDB_VERSION}/tiledb-macos-x86_64-${TILEDB_VERSION}-${COMMIT_ID}.tar.gz \
curl --location -o tiledb.tar.gz https://github.com/TileDB-Inc/TileDB/releases/download/${CORE_VERSION}/tiledb-macos-x86_64-${CORE_VERSION}-${CORE_HASH}.tar.gz \
&& sudo tar -C /usr/local -xSf tiledb.tar.gz
3 changes: 1 addition & 2 deletions .github/scripts/install_tiledb_source_linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
set -e -x
source "$(dirname $0)/tiledb-version.sh"
git clone https://github.com/TileDB-Inc/TileDB.git -b ${TILEDB_VERSION}
git clone https://github.com/TileDB-Inc/TileDB.git -b ${CORE_VERSION}
cd TileDB
mkdir build && cd build
cmake -DTILEDB_WERROR=OFF -DTILEDB_VCPKG=ON -DTILEDB_VERBOSE=OFF -DTILEDB_S3=ON -DTILEDB_SERIALIZATION=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local ..
Expand Down
3 changes: 1 addition & 2 deletions .github/scripts/install_tiledb_source_macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
set -e -x
source "$(dirname $0)/tiledb-version.sh"
git clone https://github.com/TileDB-Inc/TileDB.git -b ${TILEDB_VERSION}
git clone https://github.com/TileDB-Inc/TileDB.git -b ${CORE_VERSION}
cd TileDB
mkdir build && cd build
cmake -DTILEDB_WERROR=OFF -DTILEDB_VCPKG=ON -DTILEDB_VERBOSE=OFF -DTILEDB_S3=ON -DTILEDB_SERIALIZATION=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local ..
Expand Down
2 changes: 0 additions & 2 deletions .github/scripts/tiledb-version.sh
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions .github/workflows/tiledb-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ on:
pull_request:
branches: [ master ]

env:
# The version of TileDB to test against.
CORE_VERSION: "2.20.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the names?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find these names more descriptive than what I used before, and got inspired by Paul's unmerged PR #231.

# The abbreviated git commit hash to use.
CORE_HASH: "249c024"

jobs:
golangci:
name: lint
Expand Down
Loading