Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core.cpp (AMDGPU) #315

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update core.cpp (AMDGPU) #315

merged 3 commits into from
Dec 18, 2023

Conversation

SergeyMy
Copy link
Contributor

fixing and checking parameters

@SergeyMy
Update core.cpp (AMDGPU)
88017be 
fixing and checking parameters
TheTumultuousUnicornOfDarkness
TheTumultuousUnicornOfDarkness requested changes Dec 17, 2023
View reviewed changes
SergeyMy
SergeyMy commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@SergeyMy SergeyMy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add file_exists(amdgpu_power1_input)

@SergeyMy
Copy link
Contributor Author

drivers/gpu/drm/amd/pm/amdgpu_pm.c
/ not all products support both average and instantaneous /
that is, both _power1_input and _power1_average need to be processed with unconditional checking.

@TheTumultuousUnicornOfDarkness
Copy link
Owner

I committed my suggestion. LGTM now, thanks.

@TheTumultuousUnicornOfDarkness TheTumultuousUnicornOfDarkness merged commit 9d72bf0 into TheTumultuousUnicornOfDarkness:master Dec 18, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTumultuousUnicornOfDarkness TheTumultuousUnicornOfDarkness TheTumultuousUnicornOfDarkness requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeyMy @TheTumultuousUnicornOfDarkness