Feature/travelling salesman #12494
Feature/travelling salesman #12494
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| dp = {} | ||
| parent = {} | ||
|
|
||
| def solve(mask: int, pos: int) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman.py, please provide doctest for the function solve
| @@ -0,0 +1,16 @@ | |||
| def butterfly_pattern(n): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: butterfly_pattern. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file graphics/butterfly_pattern.py, please provide doctest for the function butterfly_pattern
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
for more information, see https://pre-commit.ci
…t and solve function comments
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| dp = {} | ||
| parent = {} | ||
|
|
||
| def solve(mask: int, pos: int) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman.py, please provide doctest for the function solve
| @@ -0,0 +1,16 @@ | |||
| def butterfly_pattern(n): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: butterfly_pattern. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file graphics/butterfly_pattern.py, please provide doctest for the function butterfly_pattern
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| dp = {} | ||
| parent = {} | ||
|
|
||
| def solve(mask: int, pos: int) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman.py, please provide doctest for the function solve
| @@ -0,0 +1,16 @@ | |||
| def butterfly_pattern(n): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: butterfly_pattern. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file graphics/butterfly_pattern.py, please provide doctest for the function butterfly_pattern
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
for more information, see https://pre-commit.ci
Feature/travelling salesman
Fixes #11938
Checklist: