Fibonacci Heap Implementation #12397
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| in the circular doubly-linked list. | ||
| """ | ||
|
|
||
| def __init__(self, key, value=None): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: key
Please provide type hint for the parameter: value
| self.next = self | ||
| self.prev = self | ||
|
|
||
| def add_child(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: add_child. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: node
| node.parent = self | ||
| self.degree += 1 | ||
|
|
||
| def remove_child(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: remove_child. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: node
| total_nodes (int): The total number of nodes in the heap. | ||
| """ | ||
|
|
||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.min_node = None | ||
| self.total_nodes = 0 | ||
|
|
||
| def is_empty(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: is_empty. If the function does not return a value, please provide the type hint as: def function() -> None:
| node.prev.next = node.next | ||
| node.next.prev = node.prev | ||
|
|
||
| def _consolidate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: _consolidate. If the function does not return a value, please provide the type hint as: def function() -> None:
| if array[i].key < self.min_node.key: | ||
| self.min_node = array[i] | ||
|
|
||
| def _link(self, node_to_link, node_to_parent): |
There was a problem hiding this comment.
Please provide return type hint for the function: _link. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: node_to_link
Please provide type hint for the parameter: node_to_parent
| node_to_parent.add_child(node_to_link) | ||
| node_to_link.mark = False | ||
|
|
||
| def _cut(self, node_to_cut, parent_node): |
There was a problem hiding this comment.
Please provide return type hint for the function: _cut. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: node_to_cut
Please provide type hint for the parameter: parent_node
| self._merge_with_root_list(node_to_cut) | ||
| node_to_cut.mark = False | ||
|
|
||
| def _cascading_cut(self, node_to_cut): |
There was a problem hiding this comment.
Please provide return type hint for the function: _cascading_cut. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: node_to_cut
| self._cut(node_to_cut, temp_parent) | ||
| self._cascading_cut(temp_parent) | ||
|
|
||
| def _iterate(self, start): |
There was a problem hiding this comment.
Please provide return type hint for the function: _iterate. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: start
Describe your change:
Checklist: