Update to typescript-eslint 8.19 #7382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
force-pushed
the
upgrade-typed-eslint
branch
from
5d16f67 to
06b2041
Compare
pjonsson
commented
Dec 18, 2024
| @@ -935,6 +935,7 @@ export default class Terria { | |||
| addShareKey(id: string, shareKey: string): void { | |||
| if (id === shareKey || this.shareKeysMap.has(shareKey)) return; | |||
| this.shareKeysMap.set(shareKey, id); | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | |||
There was a problem hiding this comment.
These x ?? y constructs are permitted with ESLint 9.17, so the directive will disappear when upgrading ESLint.
pjonsson
force-pushed
the
upgrade-typed-eslint
branch
from
06b2041 to
4b38c3c
Compare
pjonsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This depends on: #7351, #7364, #7190, #7366, and #7380.
This relates to: #7381 that upgrades the other eslint plugins to the most recent version.
This PR will only pass the CI after all the PRs it depends on are merged.
This updates to typescript-eslint 8.18, which is required for not getting a giant warning about using a more recent TypeScript than 5.4.
Besides bumping the version, this PR also converts to a new rule name in a pre-existing suppression, and adds some new suppressions in places that were hard to fix for me. The added suppressions aren't ideal, but they will allow this PR to pass the CI so it can be merged and prevent further lint issues getting added to the main branch.
Test me
Run
yarn gulp lint, so tested by CI.Checklist
doc/.