Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): adding data management icon #2101

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Feb 20, 2024

Description

Adding data management icon to covalent icon set

What's included?

  • added new data_management icon
  • including a scss font icon file now generated from ico-moon
  • fixed issue where the compute_cluster_group icon was not being generated with ligature support

Test Steps

  • npm run storybook
  • then go to the Covalent icons story
  • finally select the data_management icon from the icons list in the controls of the story

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Screenshot 2024-02-20 at 4 12 25 PM

@owilliams320 owilliams320 requested a review from adamnel February 20, 2024 21:20
@owilliams320 owilliams320 merged commit 498144d into main Feb 20, 2024
7 checks passed
@owilliams320 owilliams320 deleted the feat/icon-data-management branch February 20, 2024 21:54
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants