Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-app): upgrade packages to support angular 17 #2076

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

vicalcantFrontEnd
Copy link
Collaborator

@vicalcantFrontEnd vicalcantFrontEnd commented Nov 22, 2023

Description

This Merge Request includes updates to our project's dependencies to support Angular 17. The library and tool versions have been adjusted to ensure compatibility with the latest Angular release

What's included?

  • This changes include the upgrade to package.json to support Angular 17.

Test Steps

  • npm ci (to install dependencies exactly as per package-lock.json)
  • npm run start (to start the application)
  • then this (describe any additional steps if needed)
  • finally this (describe any final steps for testing)

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Sorry, something went wrong.

Copy link
Collaborator

@owilliams320 owilliams320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good! I just had a few comments

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@owilliams320
Copy link
Collaborator

owilliams320 commented Nov 22, 2023

@vicalcantFrontEnd also please update the README where it has the table for angular support. Before merging we will rebase with the term BREAKING in the commit message so the release will update to next Major version.

@owilliams320 owilliams320 force-pushed the feat/upgrade-packages-angular-17 branch from bb7a8eb to 7450f0b Compare January 3, 2024 14:23
@owilliams320 owilliams320 force-pushed the feat/upgrade-packages-angular-17 branch from 7450f0b to 7f06496 Compare January 3, 2024 15:01
@owilliams320 owilliams320 merged commit f6206fb into main Jan 3, 2024
7 checks passed
@owilliams320 owilliams320 deleted the feat/upgrade-packages-angular-17 branch January 3, 2024 16:34
owilliams320 pushed a commit that referenced this pull request Jan 3, 2024
BREAKING CHANGE:

Co-authored-by: Victor <victor.alcantaragarcia@teradata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants