-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs-app): upgrade packages to support angular 17 #2076
Merged
+25,199
−18,453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owilliams320
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good! I just had a few comments
@vicalcantFrontEnd also please update the README where it has the table for angular support. Before merging we will rebase with the term |
bb7a8eb
to
7450f0b
Compare
7450f0b
to
7f06496
Compare
owilliams320
approved these changes
Jan 3, 2024
owilliams320
pushed a commit
that referenced
this pull request
Jan 3, 2024
BREAKING CHANGE: Co-authored-by: Victor <victor.alcantaragarcia@teradata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Merge Request includes updates to our project's dependencies to support Angular 17. The library and tool versions have been adjusted to ensure compatibility with the latest Angular release
What's included?
Test Steps
npm ci
(to install dependencies exactly as per package-lock.json)npm run start
(to start the application)General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker