fix(markdown): external icon for target _blank #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owilliams320
force-pushed
the
fix/markdown-external-links
branch
from
3a1a254 to
75330b8
Compare
|
Need to remove the underline from the icon on hover: 
Otherwise looks good - text is wrapping above and below without the icon pushing the line-height wider on rows where it's present, which was my biggest concern. |
owilliams320
force-pushed
the
fix/markdown-external-links
branch
from
75330b8 to
d434274
Compare
adamnel
approved these changes
Feb 22, 2024
|
🎉 This PR is included in version 8.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #2063
Adding external link icon for links in markdown parsers that use
target="_blank"Test Steps
npm run startGeneral Tests for Every PR
npm run startstill works.npm run lintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to StackBlitz/Plunker