Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ios): Generating logs by default, regardless of Debug or not #3614

Merged
merged 2 commits into from
Nov 21, 2023
Merged

refactor(ios): Generating logs by default, regardless of Debug or not #3614

merged 2 commits into from
Nov 21, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Nov 16, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner November 16, 2023 12:55
@github-actions github-actions bot added module: ios size: s Denotes a PR that changes 10-99 lines labels Nov 16, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 16, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 21, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 21, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 21, 2023 08:02
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 21, 2023
@hippy-actions hippy-actions bot merged commit 7ed0049 into Tencent:main Nov 21, 2023
@wwwcg wwwcg deleted the hippy3_fix_13 branch January 12, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
module: ios size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wwwcg @ruifanyuan @open-hippy