Add places controller #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.20.0 introduces a change relating to attribute grouping and makes it incompatible. We'll pin this here and release a new version with this change so that a future breaking change can be marked as such. nickcharlton#65
`master` on Administrate is now `main`, so we can't bundle that, but it's also incompatible since nickcharlton#68, so this is an acceptable middleground to let us test for regressions.
The previous commit missed running the update command, which this does in addition to rationalising Bundler versions in the lock files.
On CI, we run using Postgres and so this shouldn't be necessary. It
should fix this failure:
sqlite3-1.7.1-x86_64-linux requires ruby version < 3.4.dev, >= 3.0, which is
incompatible with the current version, ruby 2.7.0p0
Inspired by the one on Administrate itself: https://github.com/thoughtbot/administrate/blob/main/bin/build-changelog
Originally, this project was done as part of work on Administrate itself and the license in the Gemspec has been MIT.
In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type. thoughtbot/administrate#2422 Fixes nickcharlton#65
Rebase branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.