Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5458 task: [KIUWAN] Resolve golium vulnerabilities #123

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ruben-garciad
Copy link
Contributor

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

  • Resolve golium vulnerabilities
  • Add some tests

Explain the details for making this change. What existing problem does the pull request solve?

  • OS command injection
  • HTTP parameter pollution

@ruben-garciad ruben-garciad self-assigned this Jan 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ed75922) 63.42% compared to head (e9b2166) 63.57%.

Files Patch % Lines
steps/dns/session.go 68.75% 4 Missing and 1 partial ⚠️
steps/http/session.go 93.75% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   63.42%   63.57%   +0.15%     
==========================================
  Files          48       48              
  Lines        3434     3462      +28     
==========================================
+ Hits         2178     2201      +23     
- Misses       1188     1192       +4     
- Partials       68       69       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruben-garciad ruben-garciad force-pushed the task/HDNS-5458-Resolve_golium_vulnerabilities branch from d49443d to b763299 Compare February 13, 2024 10:39
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants