Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/typescript #112

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

Feature/typescript #112

wants to merge 65 commits into from

Conversation

joheri1
Copy link

@joheri1 joheri1 commented Nov 30, 2024

Netlify link

Project Happy Thoughts TypeScript Version

For details regarding the TypeScript project, please see README-feature.md.

…and Footer inside a div. Add color to the Footer text.
…HappyWall. Add sections in the index.css file for better overview. Add HappyBoard and HappyWall components to App.jsx.
…BASE_URL and import useEffect and useState to the HappyWall component, but as comments to avoid errors.
…onospace to the button, as well as border-radius to make it oval, and background-color grey.
… useEffect to fetch Happy thoughts from the BASE_URL using an async/await function. Store the fetched thoughts in the 'thoughts' state using the setThoughts function. Include an empty dependency array in useEffect to ensure the fetch only runs once when the component mounts, preventing repeated API calls.
…ntainer for the styling. Map through the happyPosts array and use post._id as a unique key for each item/post. Add className post-box to display the message and hearts (likes). Add styling to the post-boxes and post-container.
…he return, add onClick function to add likes to a unique post
… size on the heart-icon. Style the like button.
… BASE_URL that is used in the two components HappyBoard and HappyWall. Use Async/await to fetch BASE_URL and POST the body to the HappyWall. If response is ok, clear input field. Add Error handling.
…e to the input field to prevent end-user from changing size of the field.
…icked to a darker grey for a higher contrast ratio.
joheri1 and others added 28 commits October 26, 2024 00:24
Added link to Happy Thought project in GitHib.
Add a link to README file in Github, under the Github link in the footer.
…nd alignment to fit the ”loading” text. Add link to the animated dots in the README file. Add a delay to make the loading message appear since slow internet did barely work.
…ll so the fetchHappyPosts function can be passed directly to HappyBoard as a prop (updateFormData).
…cript by updating all React components to .tsx files. Updated paths that got broken when converting.
… PostList to TypeScript. Props and , and parameter are still to be defined.
…ne happyPosts as an array of HappyPost objects. Define the state for loading as a boolean (true/false). Define that postId is a number. Add comments that start with TypeScript: where TypeScript is defined.
… HappyPost object, and one to define the PostListProps used in an array of HappyPosts and the function for adding likes to a post.
…e Main by adding ! to tell TypeScript that root is never null or undefined.
… Promise<void>. Updated README with a section explaining the Event-related TypeScript issue and how it was resolved.
…*-d-ts'. The the new file, declare that .svg files should be treated as strings
@JennieDalgren JennieDalgren self-assigned this Dec 4, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

You have converted your code to TypeScript and implemented interfaces in a great way!
All approved

Good work with the documentation in the readme too! This is super useful for anyone looking at your project to understand your workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants