Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-2-business-site #375

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

erikamolsson
Copy link

No description provided.

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Erika, great job on your business site project! I would love to visit Scotland (by train though 🚂 😉).

HTML

  • Your HTML is well-structured with clear sections for the header, main content, and form ⭐
  • Your form is well-structured and clean as well, apart from the radio buttons. The value should be different for each input (as you've already written it), but the name needs to be the same for each input so that it's interpreted as a group. In your form now, it's possible to check all of the months, which is not the point with radio buttons.
  • Keep the CSS to the CSS file, i.e. use CSS instead of the <br> tag

CSS

  • The design looks clean! The consistent use of padding, margins, and a unified color scheme contributes to this. One thing I would suggest you to improve is the readability of the text on your hero image, as the contrast is not so strong.

Changes requested

  • Group the radio buttons properly

Overall, you’ve done a really good job with this project. You've nailed the responsive design and included the necessary form elements. Just a few adjustments, such as grouping the radio buttons properly is needed. Keep up the good work!

@erikamolsson erikamolsson marked this pull request as draft September 16, 2024 09:45
Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JennieDalgren JennieDalgren marked this pull request as ready for review September 28, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants