Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor 2.0.0 #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

disbelief
Copy link

Now that Capacitor 2.0.0 is out, and Xcode 11.4 has broken Capacitor 1.x I needed to get my app working under Capacitor 2.0.0 asap.

The upgrade didn't effect the iOS code of this plugin, but on the Android side Capacitor has switched to using AndroidX.

So this PR includes the changes I needed to make to get the Android version working. Note that I am using Android Studio for development, so I needed to make some tweaks to the gradle settings and build files, and this PR also includes a few new supporting files that Android Studio adds.

@daveshirman
Copy link

Hi, I saw your other comment re android not working. Is this still the case? I am looking for a plugin I can use to record video on both iOS and Android that has to work up to date, with config options like max length quality output etc.

Your feedback would be greatly appreciated. Thanks.

@disbelief
Copy link
Author

@daveshirman at the moment I haven't been able to get Android video recording working. It crashes for me when trying to write to the file system, or possibly when simply trying to access it.

That said, I'm using a fork of the plugin with the changes in this PR. I have not tried the current master version, and can't because it's incompatible with the version of Capacitor my app is running.

Copy link

@rbenzing rbenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Def need this asap.

Copy link

@AdaLollA AdaLollA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, really need this pr please.

@mesqueeb
Copy link

@sean-perkins @triniwiz I really need this PR to be merged! Any chance you could have a look?

Base automatically changed from master to main March 9, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants