generated from Team488/FRCRobotTemplate
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal approach + AprilTagVisionSubsystemExtended #26
Open
kujo27
wants to merge
13
commits into
main
Choose a base branch
from
terminal-approach
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
reviewed
Jan 24, 2025
src/main/java/competition/subsystems/vision/MockAprilTagVisionSubsystem.java
Outdated
Show resolved
Hide resolved
kujo27
changed the title
Terminal approach + MockAprilTagVisionSubsytem
Terminal approach + AprilTagVisionSubsystemExtended
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/main/java/competition/subsystems/drive/commands/DriveToNearestReefFaceCommand.java:58
- The variable 'aKitLog' is used but not defined in the provided diff. Ensure 'aKitLog' is defined and initialized properly.
aKitLog.record("targetReefFacePose", targetReefFacePose);
src/main/java/competition/subsystems/drive/commands/AlignToReefWithAprilTagCommand.java
Outdated
Show resolved
Hide resolved
aschokking
approved these changes
Jan 26, 2025
src/main/java/competition/subsystems/drive/commands/AlignToReefWithAprilTagCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/competition/subsystems/drive/commands/AlignToReefWithAprilTagCommand.java
Show resolved
Hide resolved
src/main/java/competition/subsystems/drive/commands/AlignToReefWithAprilTagCommand.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Allows us to drive to the nearest reef face to score using SwerveSimpleTrajectoryCommand and apriltags. Also, created a subsystem to be able to simulate in advantagescope
Asana task URL:
https://app.asana.com/0/1208731987242938/1209104793195512/f
Whats changing?
New files are added: DriveToNearestReefFaceCommand, AlignToReefWithAprilTagCommand, DriveToNearestReefFaceCommandGroup, MockAprilTagVisionSubsytem
Questions/notes for reviewers
Need to push some changes to SCL for there to be no errors ( new move() in BaseSwerveDriveSubsystem, and make inputs[] public in AprilTagVisionSubsystem )
How this was tested
PR feedback legend