Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 초대 페이지 퍼블리싱 #384

Merged
merged 10 commits into from
Jan 14, 2025

Conversation

Bowoon1216
Copy link
Contributor

@Bowoon1216 Bowoon1216 commented Jan 10, 2025

해당 이슈 번호

closed #371


체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • ✅ 컨벤션을 지켰나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🙇‍♂️ 리뷰어를 지정했나요?

💎 PR Point

  • 로그인 전과 후의 뷰를 분리할까하다가 비슷해서 합쳤습니다.
  • 제가 이해한 로직이 확실하지 않아서 우선 정말 뷰만 했습니다.

📌스크린샷 (선택)

2025-01-09.202116.mp4

Copy link

🚀 Storybook 확인하기 🚀

Copy link
Contributor

@rtttr1 rtttr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~!! 보우니 이제 내일이면 한국온다 대박~~~!!

invitor: '김가온',
teamImg: '',
teamName: 'TIKI',
};

This comment was marked as resolved.

This comment was marked as resolved.

};

const InvitedPage = () => {
const isLogined = useMatch(PATH.INVITE_IN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 되어있는 상태를 나타낼거면 전역에서 관리하고 잇는 로그인 상태를 가지고 와서 확인하는 것도 좋을것 같다는 생각이 드네요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동의합니다 useLoggedIn 사용해주면 될 것 같아요 !

Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보우니 초대페이지 맡아서 해줘서 고마워 !! ❤️ LGTM

<Text tag="body4">{InviteData.invitor}님의 초대</Text>
<Flex styles={{ justify: 'center', align: 'center', gap: '0.4rem' }}>
{InviteData.teamImg ? (
<img src={InviteData.teamImg} alt="팀 프로필 이미지" />

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

답글을 이제 봤네용 감사합니다 😄

</Flex>
</Flex>
{isLogined ? (
<Flex css={{ '&, &>*': { width: '100%' }, gap: '0.4rem' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 그냥 width: 100%해줘도 되지 않나요 ??

Copy link
Contributor Author

@Bowoon1216 Bowoon1216 Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래 버튼들이 width:100%로 지정해줘야 맞게 늘어나더라구요..
그래서 하위요소들도 지정해줬습니다!

<Button size="xLarge" variant="secondary">
초대 수락
</Button>
<Button size="xLarge" css={{ color: theme.colors.sementic_red, backgroundColor: '#FFF6F7' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 컬러 theme에 추가해놓았슴다 !
theme에서 sementic_red_10 가져와서 사용해주세유 !!

};

const InvitedPage = () => {
const isLogined = useMatch(PATH.INVITE_IN);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동의합니다 useLoggedIn 사용해주면 될 것 같아요 !

Comment on lines 11 to 12
INVITE: '/invite',
INVITE_IN: '/invite-in',

This comment was marked as resolved.

This comment was marked as resolved.

Copy link

🚀 Storybook 확인하기 🚀

@Bowoon1216 Bowoon1216 merged commit 920e973 into develop Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

초대화면 및 로그인 후 초대페이지 퍼블리싱
3 participants