[Feat] 휴지통 뷰 영구삭제 및 복구 api 연결 #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 29, 2024 20:20
…to feature/deleted/#360-deleted-for-good-api
namdaeun
reviewed
Jan 5, 2025
| refetch(); | ||
| }, | ||
| onError: (error) => { | ||
| console.error('삭제 실패:', error); |
There was a problem hiding this comment.
저희 기존에 만들어놓은 toast 사용해서 삭제 실패시와 완료시 문구 띄워주는 것도 좋을 것 같넹요!!
Comment on lines
+60
to
+67
| const restoreMutation = $api.useMutation('post', '/api/v1/teams/{teamId}/trash', { | ||
| onSuccess: () => { | ||
| refetch(); | ||
| }, | ||
| onError: (error) => { | ||
| console.error('복원 실패:', error); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
$api를 사용한 mutation 코드들을 앞에서 쫙 선언해주고 핸들러들을 그 다음에 선언해주는 건 어떠신가요 ?
저의 코드스타일이기도 하지만 mutation, query 상수들을 묶어서 선언해주는 게 더 깔끔해보일 것 같다는 생각입니다..!
rtttr1
approved these changes
Jan 7, 2025
|
|
||
| const restoreMutation = $api.useMutation('post', '/api/v1/teams/{teamId}/trash', { | ||
| onSuccess: () => { | ||
| refetch(); |
There was a problem hiding this comment.
오호 삭제하면 reftch 해주기! 저도 이렇게 구현해야겠네요ㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #360
체크리스트
📌 내가 알게 된 부분
💎 PR Point
📌스크린샷
2025-01-04.195016.mp4
동영상에서 10은 복구하고 나머지는 삭제했는데 마지막에 파일에 10이 복구되고 나머진 삭제된 걸 볼 수 있습니다.