Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #241 - 코칭 3차 QA #242

Merged
merged 6 commits into from
Dec 12, 2024
Merged

[Fix] #241 - 코칭 3차 QA #242

merged 6 commits into from
Dec 12, 2024

Conversation

joonBaek12
Copy link
Contributor

@joonBaek12 joonBaek12 commented Dec 12, 2024

작업한 내용

  • CustomSegmentedControl 폰트 깨짐 이슈
  • 네비게이션 스택 이슈 수정
  • 코칭값 필터링
  • 랜덤주제 swiftUI 뷰 추가

PR Point

    func changeRootViewControllerAndPresent(_ viewControllerToPresent: UIViewController) {
        if let window = UIApplication.shared.windows.first {
            let navigationController = UINavigationController(rootViewController: viewControllerToPresent)
            window.rootViewController = navigationController
            
            UIView.transition(with: window,
                              duration: 0.5,
                              options: .transitionCrossDissolve,
                              animations: nil)
        } else {
            viewControllerToPresent.modalPresentationStyle = .overFullScreen
            self.present(viewControllerToPresent, animated: true, completion: nil)
        }
    }

기존 UIKit만으로 구성을 했을때는 SceneDelegate에서 감싸져있던 네비게이션 스택이 있어 괜찮았지만 SwiftUI와 래핑을 하면서 해당 메서드 실행시 네비게이션 스택이 사라지는 이슈가 발생했습니다. 따라서 루트뷰를 바꿔주는 과정에서 네비게이션 스택을 추가하여 해결했습니다.

스크린샷

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-12.at.01.18.08.mp4

관련 이슈

@joonBaek12 joonBaek12 requested a review from cchanmi December 12, 2024 01:56
@joonBaek12 joonBaek12 self-assigned this Dec 12, 2024
@cchanmi cchanmi changed the title [Fix] #241 - QA [Fix] #241 - 코칭 3차 QA Dec 12, 2024
Copy link
Member

@cchanmi cchanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 해 보았는데
toggle 사이즈 + 수정 팝업 취소 시 홈으로 가는 이슈 확인 부탁드립니다!

@cchanmi cchanmi merged commit dae00ac into develop Dec 12, 2024
1 check passed
@cchanmi cchanmi deleted the fix/241-QA branch January 16, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 24.12.10 QA
2 participants