Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] #233 - EditDiaryView 래핑 및 기기대응 코드 개선 #237

Merged
merged 13 commits into from
Dec 10, 2024

Conversation

joonBaek12
Copy link
Contributor

@joonBaek12 joonBaek12 commented Dec 10, 2024

작업한 내용

  • EditDiaryView 래핑
  • 기기대응 코드 개선

PR Point

extension Double {
    // 너비 기반 스케일링 (iPhone 13 mini)
    func scaledByWidth() -> Double {
        return (self / 375) * UIScreen.main.bounds.width
    }
    
    // 높이 기반 스케일링 (iPhone 13 mini)
    func scaledByHeight() -> Double {
        return (self / 812) * UIScreen.main.bounds.height
    }
}

Double의 익스텐션에 있는 scaledByWidth, Height() 메서드를 통해 가독성을 개선했습니다.

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-10.at.21.37.30.mp4

관련 이슈

@joonBaek12 joonBaek12 requested a review from cchanmi December 10, 2024 13:17
@joonBaek12 joonBaek12 self-assigned this Dec 10, 2024
Copy link
Member

@cchanmi cchanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다
일단 주석 지워 주시고 로딩, 토스트 메시지 같이 대응하면 좋을 것 같아요

@joonBaek12 joonBaek12 merged commit 4b628b9 into develop Dec 10, 2024
1 check passed
@joonBaek12 joonBaek12 deleted the chore/#233-DeviceRatio branch December 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] 기기대응 코드 개선
2 participants