[Feat] #211 - 피드백 기능 구현 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchanmi
reviewed
Aug 6, 2024
Comment on lines
112
to
115
| UIApplication.shared.open(url, options: [:]) { success in | ||
| if !success { | ||
| //에러토스트 | ||
| } |
There was a problem hiding this comment.
error publisher로 값을 보내 줘서 처리하면 될 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업한 내용
구글폼 바로가기 누르면 safari로 다이렉팅되게 구현했습니다.
PR Point
google
네비게이션바를 제가 컴포넌트화한걸로 교체해도 될까요?!?
스크린샷
관련 이슈