Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - 중복된 유저 회원가입 되지 않도록 수정 #99

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

kseysh
Copy link
Member

@kseysh kseysh commented Feb 3, 2024

Related issue 🚀

Work Description 💚

  • 중복된 유저가 회원가입 되지 않도록 수정하였습니다.

PR 참고 사항

  • 회원가입의 중복이 클라이언트의 중복된 요청 전송 이외에는 일어나지 않을 일일 것이라 판단하여 동시성 문제를 해결하는 방식보다 DB에 제약을 두는 방식이 나을 것이라고 판단하였습니다. (동시성 문제를 해결하는 방식으로 해결하면 회원가입 로직이 불필요하게 복잡해질 수 있다고 판단하였습니다!)

@kseysh kseysh added ☁️ Database DB 관련 👨🏻‍💻 승환 승환이가 작성한 Label 🐞 BugFix 에러 수정, 버그 수정 🔥 Pull Request labels Feb 3, 2024
@kseysh kseysh requested a review from jumining February 3, 2024 05:02
@kseysh kseysh self-assigned this Feb 3, 2024
Copy link
Collaborator

@jumining jumining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 간단하게 수정하셨네요 :)

@jumining jumining merged commit 9de51dc into develop Feb 22, 2024
1 check passed
@jumining jumining deleted the fix/#83-signup-duplicate-user-error branch November 19, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 BugFix 에러 수정, 버그 수정 ☁️ Database DB 관련 👨🏻‍💻 승환 승환이가 작성한 Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix - 중복된 유저 회원가입 되지 않도록 수정
2 participants