Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat - 유저 정보 불러오기 기능 구현 #23

Merged
merged 36 commits into from
Jan 10, 2024
Merged

feat - 유저 정보 불러오기 기능 구현 #23

merged 36 commits into from
Jan 10, 2024

Conversation

kseysh
Copy link
Member

@kseysh kseysh commented Jan 9, 2024

Related issue 🚀

Work Description 💚

  • 유저 정보 불러오기 기능을 구현했습니다.
  • Util 클래스를 만들고 access token을 이용해 유저의 아이디를 불러오는 getUserId 함수를 추가했습니다. 이를 유저 정보가 필요한 코드에서 사용하시면 될 것 같습니다.

PR 참고 사항

  • 아래는 포스트맨 테스트 결과입니다.
    image

kseysh added 18 commits January 9, 2024 12:14
@kseysh
feat - #13 회원가입 기능 구현
f6a9725
@kseysh
merge - #13 #18 브랜치를 pull 받아 merge
3794fd3
@kseysh
refactor - #18 사용하지 않는 파일 삭제
97111ce
@kseysh
chore - #18 request파일의 네이밍 request로 변경
2e49b3e
@kseysh
del - #18 사용하지 않는 파일 삭제
165e861
@kseysh
chore - #18 response 폴더 네이밍 request로 변경
53f8c6e
@kseysh
feat - #18 OnboardingInfo 객체 추가
95b7681
@kseysh
feat - #18 회원가입 로직 구현
8ab3e95
@kseysh
refactor - #18 기능이 더 명확하게 표현되는 함수 네이밍으로 수정
b212be1
@kseysh
refactor - #18 공통된 메서드 추출을 통한 리팩토링과 명확한 기능 설명을 위한 함수 네이밍 수정
0ada677
@kseysh
refactor - #18 불필요한 토큰 파싱과정 삭제
7f1d5c6
@kseysh
merge - #18 develop 브랜치와 merge
adf9ea1
@kseysh
merge - #18 PR전 develop 브랜치와 merge
8721b50
@kseysh
feat - #22 Util 클래스를 추가하여 전역에서 userId를 가져오는 코드 생성
7741811
@kseysh
chore - #22 controller 네이밍 컨벤션에 맞게 변경
eea879a
@kseysh
chore - #22 tokenDto 네이밍 tokenResponse로 변경
90e06ca
@kseysh
feat - #22 유저 정보 불러오기 기능 구현
4b84835
@kseysh
chore - #22 이후 포인트 사용 api를 위한 isSuccess값 true로 변경
c982333
@kseysh kseysh added 🪄 API ✨ Feat 새로운 기능 추가 👨🏻‍💻 승환 승환이가 작성한 Label labels Jan 9, 2024
@kseysh kseysh requested a review from jumining January 9, 2024 13:50
@kseysh kseysh self-assigned this Jan 9, 2024
jumining
jumining reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@jumining jumining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저정보 불러오는데 수정된 코드가 많군요 수고하셨습니다!

src/main/java/sopt/org/HMH/domain/challenge/dto/request/ChallengeRequest.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/dayChallenge/domain/DayChallenge.java Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/domain/OnboardingInfo.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/domain/OnboardingInfo.java Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/domain/OnboardingProblem.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/domain/user/domain/User.java Outdated Show resolved Hide resolved
src/main/java/sopt/org/HMH/global/common/Util.java Show resolved Hide resolved
jumining
jumining approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@jumining jumining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘 확인했습니다 얼른 머지되면 좋겠군요 두근두근

@kseysh kseysh merged commit 5036a70 into develop Jan 10, 2024
1 check passed
@jumining jumining deleted the feat/#22-get-user-info-api branch January 15, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumining jumining jumining approved these changes

Assignees

@kseysh kseysh

Labels
✨ Feat 새로운 기능 추가 👨🏻‍💻 승환 승환이가 작성한 Label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat - 유저 정보 불러오기 기능 추가
2 participants
@kseysh @jumining