feat - 회원가입 기능 구현 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumining
approved these changes
Jan 10, 2024
| import java.util.List; | ||
|
|
||
| public record OnboardingRequest( | ||
|
|
There was a problem hiding this comment.
P2. record에는 빈 줄 빼는 것으로 통일해요!:)
| import sopt.org.HMH.global.auth.social.SocialPlatform; | ||
|
|
||
| public record SocialSignUpRequest( | ||
|
|
Comment on lines
9
to
13
| SocialPlatform socialPlatform, | ||
| @JsonProperty(value = "onboarding") | ||
| OnboardingRequest onboardingRequest, | ||
| @JsonProperty(value = "challenge") | ||
| ChallengeRequest challengeRequest |
There was a problem hiding this comment.
P2. 위에는 애노테이션과 변수 사이에 빈줄이 있고 이 레코드 파일에는 빈줄이 없는 것 같아서 통일해주면 좋을 것 같아요이
There was a problem hiding this comment.
넵 어노테이션에서는 위에 공백을 붙이는 것으로 통일하도록 하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항