refactor - #9 이름 및 exception 처리 코드 위치 변경

src/main/java/sopt/org/HMH/domain/app/service/AppService.java

@@ -5,8 +5,6 @@
 import sopt.org.HMH.domain.app.domain.App;
 import sopt.org.HMH.domain.app.dto.request.AppGoalTimeRequest;
 import sopt.org.HMH.domain.app.repository.AppRepository;
-import sopt.org.HMH.domain.challenge.domain.exception.ChallengeError;
-import sopt.org.HMH.domain.challenge.domain.exception.ChallengeException;
 import sopt.org.HMH.domain.dayChallenge.domain.DayChallenge;
 import sopt.org.HMH.domain.dayChallenge.repository.DayChallengeRepository;
 
@@ -20,12 +18,11 @@ public class AppService {
     private final AppRepository appRepository;
     private final DayChallengeRepository dayChallengeRepository;
 
-    public List<App> addApp(Long dayChallengeId, List<AppGoalTimeRequest> responses) {
-        DayChallenge dayChallenge = dayChallengeRepository.findById(dayChallengeId)
-                .orElseThrow(() -> new ChallengeException(ChallengeError.CHALLENGE_NOT_FOUND));
+    public List<App> addApp(Long dayChallengeId, List<AppGoalTimeRequest> requests) {
+        DayChallenge dayChallenge = dayChallengeRepository.findByIdOrThrowException(dayChallengeId);
 
         List<App> apps = new ArrayList<>();
-        for (AppGoalTimeRequest response: responses) {
+        for (AppGoalTimeRequest response: requests) {
             appRepository.save(new App(dayChallenge, response.appCode(), response.goalTime()));
         }
 

src/main/java/sopt/org/HMH/domain/challenge/service/ChallengeService.java

@@ -12,8 +12,6 @@
 import sopt.org.HMH.domain.user.User;
 import sopt.org.HMH.domain.user.service.UserService;
 
-import java.util.List;
-
 @Service
 @RequiredArgsConstructor
 public class ChallengeService {

src/main/java/sopt/org/HMH/domain/dayChallenge/repository/DayChallengeRepository.java

@@ -1,7 +1,13 @@
 package sopt.org.HMH.domain.dayChallenge.repository;
 
+import jakarta.persistence.EntityNotFoundException;
 import org.springframework.data.jpa.repository.JpaRepository;
 import sopt.org.HMH.domain.dayChallenge.domain.DayChallenge;
+import sopt.org.HMH.domain.user.exception.UserError;
 
 public interface DayChallengeRepository extends JpaRepository<DayChallenge, Long> {
+
+    default DayChallenge findByIdOrThrowException(Long dayChallengeId) {
+        return findById(dayChallengeId).orElseThrow(() -> new EntityNotFoundException(UserError.USER_NOT_FOUND.getErrorMessage()));
+    }
 }

src/main/java/sopt/org/HMH/domain/user/repository/UserRepository.java

@@ -1,7 +1,13 @@
 package sopt.org.HMH.domain.user.repository;
 
+import jakarta.persistence.EntityNotFoundException;
 import org.springframework.data.jpa.repository.JpaRepository;
 import sopt.org.HMH.domain.user.User;
+import sopt.org.HMH.domain.user.exception.UserError;
 
 public interface UserRepository extends JpaRepository<User, Long> {
+
+    default User findByIdOrThrowException(Long userId) {
+        return findById(userId).orElseThrow(() -> new EntityNotFoundException(UserError.USER_NOT_FOUND.getErrorMessage()));
+    }
 }

src/main/java/sopt/org/HMH/domain/user/service/UserService.java

@@ -1,10 +1,8 @@
 package sopt.org.HMH.domain.user.service;
 
-import jakarta.persistence.EntityNotFoundException;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import sopt.org.HMH.domain.user.User;
-import sopt.org.HMH.domain.user.exception.UserError;
 import sopt.org.HMH.domain.user.repository.UserRepository;
 
 @Service
@@ -14,7 +12,6 @@ public class UserService {
     private final UserRepository userRepository;
 
     public User getUserId(Long userId) {
-        return userRepository.findById(userId)
-                .orElseThrow(() -> new EntityNotFoundException(UserError.USER_NOT_FOUND.getErrorMessage()));
+        return userRepository.findByIdOrThrowException(userId);
     }
 }