Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat/database] : Room Database 추가 작업 #22

Merged
merged 5 commits into from
Jan 1, 2024
Merged

Conversation

kez-lab
Copy link
Member

@kez-lab kez-lab commented Jan 1, 2024

개요

작업 사항

  • Room Gradle Plugin 추가
  • Room Hilt Module 추가
  • Sample Model, Dao 추가

변경 사항(optional)

  • Timber 라이브러리 삭제
  • app module 종속성 추가

@kez-lab kez-lab added 🐱의진 의진이 작업 💻feat 새로운 기능 추가 labels Jan 1, 2024
@kez-lab kez-lab self-assigned this Jan 1, 2024
@kez-lab kez-lab requested a review from a team as a code owner January 1, 2024 06:03
@@ -31,6 +31,5 @@ internal fun Project.configureAndroidCommonPlugin() {
"implementation"(libs.findLibrary("appcompat").get())
"implementation"(libs.findBundle("lifecycle").get())
"implementation"(libs.findLibrary("material").get())
"implementation"(libs.findLibrary("timber").get())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timber 추가 안했다고 했었는데 셋팅해두었다가 뺀건가용??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init을 안했다는 얘기였습니당~!!

@kez-lab kez-lab merged commit 85c079e into develop Jan 1, 2024
1 check passed
@kez-lab kez-lab deleted the feat/database branch January 1, 2024 14:49
@@ -11,6 +11,7 @@ kotlinx-serialization-json = "1.6.0"
kotlinx-serialization-converter = "1.0.0"
kotlinx-coroutines = "1.7.3"
kotlinx-datetime = "0.4.1"
ksp = "1.8.21-1.0.11"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlin 버전하고 맞춰야하지 않나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 감사합니다! 해당 부분 다음 pr에서 수정하도록 하겠습니다😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐱의진 의진이 작업 💻feat 새로운 기능 추가
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat]: Room 기초 셋팅
3 participants