Fix order of calloc() args #639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these were done upstream in:
2023-10-18 Use calloc arguments that correspond with the...
libarchive 2edd8819501023bc909869b7b652b55edfa7342e
Note that libarchive renamed archive_read_support_compression_* to
archive_read_support_filter_*.
The remaining two cases of fixed "calloc(sizeof" were in code which had
been deleted upstream.
Reported by: gcc-15
gperciva
commented
Feb 11, 2025
| @@ -183,7 +183,7 @@ bzip2_reader_init(struct archive_read_filter *self) | |||
| self->code = ARCHIVE_COMPRESSION_BZIP2; | |||
| self->name = "bzip2"; | |||
|
|
|||
| state = (struct private_data *)calloc(sizeof(*state), 1); | |||
| state = (struct private_data *)calloc(1, sizeof(*state)); | |||
There was a problem hiding this comment.
Yes, that cast is a silly C++ism, but the commit I mentioned only fixed the order of calloc, so I left the cast unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.