Add --dry-run-metadata #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gperciva
force-pushed
the
dry-run-metadata
branch
from
a363942 to
1923dba
Compare
gperciva
commented
Dec 22, 2023
tar/multitape/multitape_write.c
Outdated
| { | ||
|
|
||
| /* Create chunkifier. */ | ||
| if (!no_chunkifier) { | ||
| if (use_chunkifier) { |
There was a problem hiding this comment.
When I looked at the code again, I really didn't like the (!no_chunkifier) part.
|
I prefer |
gperciva
force-pushed
the
dry-run-metadata
branch
from
1923dba to
c0e4bec
Compare
|
Ok, I removed the REBASE commit. As far as I know, this is ready for merging. |
|
Please fix |
gperciva
force-pushed
the
dry-run-metadata
branch
from
c0e4bec to
0dd6e10
Compare
The only interesting facets of this commit are: - internally, we store this as bsdtar->option_dryrun == 2; the existing --dry-run option is stored as 1. - we disallow the combination of --dry-run-metadata with --print-stats, because the --print-stats (generated from the chunk layer) would only report metadata and metaindex bytes (since no filesystem data will reach the chunk layer).
If we've been given --dry-run-metadata, then we only care about the total number of bytes in each file, not the contents.
We use the same technique for storage_write.c: if we don't want to use the storage layer (in that case, due to --dry-run), we set the storage cookie to NULL. The next commit will do the same for the chunk layer: if we don't want to use it (due to --dry-run-meta), we'll set the chunkification cookie to NULL. chunkify_free() already does a no-op for NULL.
Disabling chunkification also stops any file or header data from reaching the chunk layer. Metadata and metaindex bytes are unaffected by this change; those are still passed on. This is not a deliberate choice; it's just a bit more awkward to stop those bytes from going to the chunk layer, and since we disabled the combination of --print-stats with --dry-run-metadata in bsdtar.c, it doesn't matter if those bytes are passed on. There's no noticeable performance impact of metadata and metaindex bytes.
These changes were made automatically via scripts.
gperciva
force-pushed
the
dry-run-metadata
branch
from
0dd6e10 to
7ac0a07
Compare
|
Rebased. Also fixed a comment in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.