Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**perf** improve perf, as discussed in #8091 #8092

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

**perf** improve perf, as discussed in #8091 #8092

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7618bdf
[perf] improve perf, as discussed in #8091
joeljeske Sep 23, 2024
990fe9c
Merge branch 'main' into perf/proxy-insteadoxy-instead-of-define-prop
TkDodo Oct 1, 2024
be6a9ae
Merge branch 'main' into perf/proxy-insteadoxy-instead-of-define-prop
TkDodo Oct 9, 2024
652ab25
Merge branch 'main' into perf/proxy-insteadoxy-instead-of-define-prop
Aghassi Dec 3, 2024
e1e5ae3
Merge branch 'main' into perf/proxy-insteadoxy-instead-of-define-prop
TkDodo Dec 6, 2024
d16cac0
Merge branch 'main' into perf/proxy-insteadoxy-instead-of-define-prop
Aghassi Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions packages/query-core/src/queryObserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,18 +273,14 @@ export class QueryObserver<
result: QueryObserverResult<TData, TError>,
onPropTracked?: (key: keyof QueryObserverResult) => void,
): QueryObserverResult<TData, TError> {
const trackedResult = {} as QueryObserverResult<TData, TError>

Object.keys(result).forEach((key) => {
Object.defineProperty(trackedResult, key, {
configurable: false,
enumerable: true,
get: () => {
const trackedResult = new Proxy(result, {
get: (target, key) => {
if (key in target) {
this.trackProp(key as keyof QueryObserverResult)
onPropTracked?.(key as keyof QueryObserverResult)
return result[key as keyof QueryObserverResult]
},
})
return target[key as keyof QueryObserverResult]
}
},
})

return trackedResult
Expand Down
Loading