Adding atomic distro support #96
Conversation
|
#92 this is a possible solution for this issue! |
|
Hi @butu, Thank you for your time and contribution! Due to my lack of knowledge about atomic distros, I would like to wait for a double confirmation before merging this PR once it seems ready. In the meantime, here is some feedback. I would also like to know your opinion on PR #94 (the installation part of it), and if it would cause any problems for an atomic installation. Have a nice day. |
Oh absolutely!
Ah, I will try this one!
As well and thank you! |
| BIN_DIR="/var/usrlocal/bin" | ||
| CONF_DIR="/etc" | ||
| LIB_DIR="/etc" |
There was a problem hiding this comment.
Hi, I am not an atomic distribution specialist, but I think these absolute paths can change depending on the os/user configuration.
I think it might be better to let the user (or packaging solution) define them instead (in a similar way to "DEST_DIR", "PREFIX_DIR"...).
e.g. adding a "lib-dir" option that overrides the "$DEST_DIR$PREFIX_DIR/lib" default when set (to be defined).
Hi,
I worked through the installation script and found a way to install everything so fw-fanctrl also works on atomic distros!
Basically I introduced a few new path variables, which are overriden when setting the --atomic argument.
So to install fw-fanctrl on an atomic distro, you would call
sudo ./install.sh --atomic.I tested and am using this on Bluefin. So it should work on any Silverblue Distro.
I tested the default installation in a distrobox only, and I think everything still works for standard distros.
I am quite new to atomic distros, so I am not 100% sure that this is the best way to do this. Any feedback welcome, I am happy to make some changes! :