Show side abbrevations on the motion statistics page again. #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienne-B
reviewed
Oct 31, 2024
tabbycat/motions/statistics.py
Outdated
| @@ -236,16 +244,17 @@ def _collate_prelim_motion_annotations(self): | |||
| motion.counts_by_bench = {'gov': 0, 'opp': 0} | |||
|
|
|||
| for side in self.tournament.sides: | |||
| side_abbrv = abbrv_of_bp_side(side) | |||
There was a problem hiding this comment.
Should use tournaments.utils.get_side_name like:
side_abbr = get_side_name(side, 'abbr')Then we wouldn't need the new function.
Does this also affect two-team formats? Should also fix there.
There was a problem hiding this comment.
Thanks! I've updated it to use that function.
I don't believe it affects two-team formats (e.g. here this problem doesn't seem to exist https://edudrift.calicotab.com/australs2024/motions/statistics/).
Tabbycat used to show side names, but at some point this broke. This commit fixes this.
teymour-aldridge
force-pushed
the
stats
branch
from
ae7f9ba to
94cfea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabbycat used to show side names, but at some point this broke. This commit fixes this.