Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default to bye room ranks #2368

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Add default to bye room ranks #2368

merged 1 commit into from
Dec 31, 2023

Conversation

tienne-B
Copy link
Member

@tienne-B tienne-B commented Dec 9, 2023

If there are no pairings in a round, the draw generation fails due to not having the room rank to use when creating bye "debates" (even if there are no byes). We default to 0, in order to give them the room rank of 1.

Fixes BACKEND-BWA

If there are no pairings in a round, the draw generation fails due to
not having the room rank to use when creating bye "debates" (even if
there are no byes). We default to 0, in order to give them the room
rank of 1.

Fixes BACKEND-BWA
@tienne-B tienne-B merged commit 12bd80e into develop Dec 31, 2023
3 checks passed
@tienne-B tienne-B deleted the BACKEND-BWA branch December 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant