Add ability to disable team-judge feedback and judge-judge feedback independently #2309
Conversation
daankoning
changed the title
|
Oh, sorry for ignoring this! I'm somewhat far from home right now. I think we're on the right path, but the preference should also affect the "Feedback Progress" pages, and public/assistant/admin feedback submission pages. I also don't see how this resolves #1683, as that would require a new setting for the |
|
Sorry for taking absolutely ages to get back to this. Wish I could say I had some cool excuse but honestly life just happened and I forgot. Regardless, very valid criticisms. I believe I have addressed most of them . Thank you so much for the constructive helpful advice 😄. |
| @@ -256,7 +256,7 @@ def __str__(self): | |||
|
|
|||
| def _unique_unconfirm_args(self): | |||
| kwargs = super()._unique_unconfirm_args() | |||
| if self.source_team is not None and self.source_team.debate.round.tournament.pref('feedback_from_teams') != 'all-adjs': | |||
| if self.source_team is not None and self.source_team.debate.round.tournament.pref('feedback_from_teams') == 'orallist': | |||
There was a problem hiding this comment.
Not quite sure about this... if the setting is for no one, then we shouldn't even reach here as no options should appear.
closes #1683 and closes #1873