Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add v 11 compatibility #5

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

pgreban
Copy link

@pgreban pgreban commented Nov 16, 2021

Added compatibility for v11 while keeping compatibility for older versions

@mabolek
Copy link
Contributor

mabolek commented Nov 17, 2021

@pgreban Thank you for the PR! I ran the CI workflow and it seems to be a problem with unit tests in v11. It looks Guzzle-related.

@pgreban
Copy link
Author

pgreban commented Nov 17, 2021

I think I know where it comes from. I need to find a way to keep the compatibility for older versions.

@pgreban
Copy link
Author

pgreban commented Nov 17, 2021

Why are some tests canceled? For example 9.5/7.4

@mabolek
Copy link
Contributor

mabolek commented Nov 17, 2021

If a certain amount of checks fail, others are simply stopped. Saves CPU time.

@Rall3n
Copy link

Rall3n commented Apr 28, 2022

As a user who has encountered problems with TYPO3v11 and this extension I believe the problem is the old age of the Hubspot PHP Interface included as a .phar file.

Even though the library includes its own Guzzle implementation (~6.0), it falls back to the TYPO3 Guzzle dependency, which is a more recent version (^7.3.0). Therefore it throws issues due to now non-existent functions and/or classes (either on TYPO3 or Hubspot-PHP site).

You would have to update the included Hubspot-PHP library (and the composer dependency) to its newest version for v11 compatibility.

@mabolek
Copy link
Contributor

mabolek commented Apr 28, 2022

Hi @Rall3n!

Have you tried running the extension in a Composer-based TYPO3 installation?

I think the long-term solution is to drop support for non-composer installs. The extension is currently supporting a wide range of TYPO3 and PHP versions, which makes it hard to include any libraries in the package without compatibility issues.

@Rall3n
Copy link

Rall3n commented Apr 28, 2022

Hi @Rall3n!

Have you tried running the extension in a Composer-based TYPO3 installation?

I think the long-term solution is to drop support for non-composer installs. The extension is currently supporting a wide range of TYPO3 and PHP versions, which makes it hard to include any libraries in the package without compatibility issues.

Unfortunately the system I require this extension for is not running in composer mode, and conversion is not an option.

It may be the right decision maintenance wise, but removing TER support would abandon everyone who is not able to use composer on their servers/webhosts.

@Lefaux
Copy link

Lefaux commented Apr 28, 2022

just as a sidenote here:
composer is not supposed to run on the webserver in the first place ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants