Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 27, AttributeError when calculating fuel flow for A21N #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmonstein
Copy link

Fixing issue #27

There are minimal changes, but it needs to be checked if I used the package in an unintended way.

@rmonstein
Copy link
Author

Additionally, I corrected the confusing text of an exception. If I understood the code correctly, the exception refers to the fuel model, not the drag polar.

@rmonstein
Copy link
Author

What is still a bit confusing to me in the fuel flow model is the way how it is computed. The fuel flow seems to be computed solely based on one coefficient and the thrust ratio (lines 20 to 21 and its use in at_trhust). Is there any reference for that formula and the coefficients?
The paper "OpenAP: An Open-Source Aircraft Performance Model for Air Transportation Studies and Simulations" has, as far as I can tell, describes a different method to calculate the fuel flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant