Multistate #53
Merged
Multistate #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-posev
reviewed
Dec 18, 2024
q-posev
reviewed
Dec 18, 2024
| def run(trexio_filename, filename, filetype, back_end, spin=None, motype=None, state_suffix=None): | ||
|
|
||
| # Do the cleanup if the file already exists | ||
| file_cleanup(trexio_filename, back_end) |
There was a problem hiding this comment.
we now have remove_trexio_file function which works nicely with the --overwrite CLI option. Do we really need to do file_cleanup here?
There was a problem hiding this comment.
Done!
I changed the command line option from "-w True" to "-w". The presence of -w sets overwrite to True, the absence to False. It is more common for boolean command-line values.
There was a problem hiding this comment.
Yes, I know how to do that with argparse (which is what I use for CLI nowadays) but docopt is confusing sometimes. Thanks!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the changes requested in #40 . I suggest that we merge this branch and close #40