Fix Get-Apache and build-task #59
Open
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-apache.ps1 had a bug due to changes in the Apache Lounge.
The default download page is VS16 and the regular expression had to be changed to detect the VC/VS version:
(V[CS]\d+)In addition to the above, now the download links are not full paths:
/download/VS16/binaries/httpd-2.4.53-win64-VS16.zip.build-task.cmd had a bug where it always ended with an error. The problem is that the script expects
mod_authn_ntlm.dllwhen the build output generatesmod_authn_ntlm.so.Now regardless of whether it generates a
.dllor.sothe binary is correctly detected and does not throw a false error.