WIP: Fix bug in Knowledge Gap detection with duplicate triples #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also group the configuration keys in a dedicated *Config class.
We no longer use environment variables directly, but we do that through MicroProfile Config implementation. Values are automatically overridden by users using environment variables or Java system properties. We can determine whether a value was overridden by checking whether the ConfigValue#getSourceOrdinal() of a configuration value is > 100.
At a later stage we also need to update the documentation in the ./docs/ folder.
Does not work yet.
…orithm # Conflicts: # smart-connector/src/main/java/eu/knowledge/engine/smartconnector/impl/Util.java
They work correctly now.
WIP: Improve documentation
Bumps `jetty-version` from 11.0.15 to 11.0.24. Updates `org.eclipse.jetty:jetty-util` from 11.0.15 to 11.0.24 Updates `org.eclipse.jetty:jetty-servlet` from 11.0.15 to 11.0.24 Updates `org.eclipse.jetty:jetty-server` from 11.0.15 to 11.0.24 --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-util dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.eclipse.jetty:jetty-servlet dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.eclipse.jetty:jetty-server dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps org.apache.maven:maven-model from 3.9.4 to 3.9.9. --- updated-dependencies: - dependency-name: org.apache.maven:maven-model dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ch.qos.logback:logback-core from 1.4.14 to 1.5.12 Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.4.14 to 1.5.12. - [Commits](qos-ch/logback@v_1.4.14...v_1.5.12) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Remove logback dependency --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lathouwerssam <[email protected]>
Bumps `jackson-version` from 2.18.1 to 2.18.2. Updates `com.fasterxml.jackson.datatype:jackson-datatype-joda` from 2.18.1 to 2.18.2 - [Commits](FasterXML/jackson-datatype-joda@jackson-datatype-joda-2.18.1...jackson-datatype-joda-2.18.2) Updates `com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider` from 2.18.1 to 2.18.2 Updates `com.fasterxml.jackson.core:jackson-core` from 2.18.1 to 2.18.2 - [Commits](FasterXML/jackson-core@jackson-core-2.18.1...jackson-core-2.18.2) Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.18.1 to 2.18.2 - [Commits](https://github.com/FasterXML/jackson/commits) Updates `com.fasterxml.jackson.datatype:jackson-datatype-jsr310` from 2.18.1 to 2.18.2 Updates `com.fasterxml.jackson.core:jackson-databind` from 2.18.1 to 2.18.2 - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-joda dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.fasterxml.jackson.core:jackson-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.fasterxml.jackson.core:jackson-annotations dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-jsr310 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `swagger-core-version` from 2.2.22 to 2.2.26. Updates `io.swagger.core.v3:swagger-jaxrs2-jakarta` from 2.2.22 to 2.2.26 Updates `io.swagger.core.v3:swagger-jaxrs2-servlet-initializer-v2-jakarta` from 2.2.22 to 2.2.26 --- updated-dependencies: - dependency-name: io.swagger.core.v3:swagger-jaxrs2-jakarta dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.swagger.core.v3:swagger-jaxrs2-servlet-initializer-v2-jakarta dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o-make-meta-functionality-reusable 581 update admin UI implementation to make meta functionality reusable
* Add workflow for (1) drafting release, (2) uploading Docker images * Allow manual trigger for docker image uploads and update path to JARs for draft release * Update release steps in documentation * Skip maven tests in CI for draft release and Docker image * Explicitly mention in 'Release steps' that you need to make a new branch
Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.11.3 to 5.11.4. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.11.3...r5.11.4) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `swagger-core-version` from 2.2.26 to 2.2.27. Updates `io.swagger.core.v3:swagger-jaxrs2-jakarta` from 2.2.26 to 2.2.27 Updates `io.swagger.core.v3:swagger-jaxrs2-servlet-initializer-v2-jakarta` from 2.2.26 to 2.2.27 --- updated-dependencies: - dependency-name: io.swagger.core.v3:swagger-jaxrs2-jakarta dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.swagger.core.v3:swagger-jaxrs2-servlet-initializer-v2-jakarta dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Prepare for release 1.3.0
Prepare 1.3.1-SNAPSHOT
…ection-algorithm' into 519-fix-bug-in-knowledge-gap-detection-algorithm # Conflicts: # smart-connector/src/test/java/eu/knowledge/engine/smartconnector/api/TestKnowledgeGapDetection.java
|
Closing this PR as I messed up the git history. New PR available at #594 |
Sophietje
deleted the
519-fix-bug-in-knowledge-gap-detection-algorithm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519