Feat(vipps)/check payment #943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadsNyl
requested changes
Jan 23, 2025
app/payment/urls.py
Outdated
| urlpatterns = [re_path(r"", include(router.urls))] | ||
| urlpatterns = [ | ||
| re_path(r"", include(router.urls)), | ||
| path("check-vipps-payment", check_vipps_payment), |
There was a problem hiding this comment.
Kan gjøre url'en lettere her ved f.eks "check-payment"
app/payment/views/vipps_util.py
Outdated
Comment on lines
9
to
35
| @api_view(["POST"]) | ||
| def check_vipps_payment(self, request, *args, **kwargs): | ||
| has_changed = False | ||
|
|
||
| serializer = CheckPaymentSerializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
|
|
||
| event_id = serializer.validated_data["event_id"] | ||
| user_id = serializer.validated_data["user_id"] | ||
|
|
||
| orders = self.queryset.filter(user_id=user_id, event_id=event_id) | ||
| if not orders.exists(): | ||
| return Response( | ||
| {"message": "No orders found for the user in this event."}, | ||
| status=status.HTTP_404_NOT_FOUND, | ||
| ) | ||
|
|
||
| for order in orders: | ||
| order_status = get_payment_order_status(order.order_id) | ||
| if order_status != order.status: | ||
| has_changed = True | ||
| order.status = order_status | ||
| order.save() | ||
|
|
||
| if has_changed(order): | ||
| return Response({"is_paid": True}, status=status.HTTP_200_OK) | ||
| return Response({"is_paid": False}, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
Her må dere implementere aksesskontroll. Dere må sjekke om den som sender requesten har lov til å redigere dette eventet. Sjekk ut logikken på dette for edit på events
|
Ska funke som det skal no :) |
MadsNyl
requested changes
Jan 24, 2025
…ing group can update an order
MadsNyl
requested changes
Jan 25, 2025
app/payment/views/vipps_util.py
Outdated
Comment on lines
41
to
43
| if has_changed(order): | ||
| return Response({"is_paid": True}, status=status.HTTP_200_OK) | ||
| return Response({"is_paid": False}, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
Endre disse til "details" siden det er den nøkkelen frontend sjekker etter
…on more explanatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented an option to check if the vipps payment have been done.